[webkit-reviews] review denied: [Bug 28938] CSS string value is not correctly serialized when it contains binary characters : [Attachment 38979] Escape control characters in CSS string value when it is serialized.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuta Kitamura <yutak at chromium.org>'s
request for review:
Bug 28938: CSS string value is not correctly serialized when it contains binary
characters
https://bugs.webkit.org/show_bug.cgi?id=28938

Attachment 38979: Escape control characters in CSS string value when it is
serialized.
https://bugs.webkit.org/attachment.cgi?id=38979&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This would be much better as a js test/dom only test:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

YOu'd get shouldBeEqualToString for fre, instead of having to make your own
pass/fail functions.

This also doesn't need to be run from onload, you can run this from an inline
script tag (which making this a js test will do automatically).

No argument names needed here since tehy don't add clarity:
6 String quoteCSSString(const String& string);
 217 String quoteCSSStringIfNeeded(const String& string);
 218 String quoteCSSURLIfNeeded(const String& string);