[webkit-reviews] review granted: [Bug 27899] [Gtk] Expose a database API : [Attachment 39037] Update patch rev5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 22:18:53 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 27899: [Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899

Attachment 39037: Update patch rev5
https://bugs.webkit.org/attachment.cgi?id=39037&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> diff --git a/GNUmakefile.am b/GNUmakefile.am
> index 53a04cd..41806e4 100644
> --- a/GNUmakefile.am
> +++ b/GNUmakefile.am
> @@ -331,6 +331,7 @@ webkitgtk_h_api += \
>	$(srcdir)/WebKit/gtk/webkit/webkitwebsettings.h \
>	$(srcdir)/WebKit/gtk/webkit/webkitwebwindowfeatures.h \
>	$(srcdir)/WebKit/gtk/webkit/webkitwebview.h \
> +	$(srcdir)/WebKit/gtk/webkit/webkitwebdatabase.h \
>	$(top_builddir)/WebKit/gtk/webkit/webkitversion.h
>  
>  webkitgtk_built_sources += \
> @@ -372,6 +373,10 @@ webkitgtk_sources += \
>	WebKit/gtk/webkit/webkitwebnavigationaction.cpp \
>	WebKit/gtk/webkit/webkitwebpolicydecision.cpp \
>	WebKit/gtk/webkit/webkitwebresource.cpp \
> +	WebKit/gtk/webkit/webkitwebdatabase.cpp \
> +	WebKit/gtk/webkit/webkitwebdatabase.h \
> +	WebKit/gtk/webkit/webkitsecurityorigin.cpp \
> +	WebKit/gtk/webkit/webkitsecurityorigin.h \

Should the header be in the API section?

Other than that looks great! r=me.


More information about the webkit-reviews mailing list