[webkit-reviews] review granted: [Bug 28962] Remove unnecessary dependency on unistd.h in Completion.cpp : [Attachment 39032] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 3 22:00:29 PDT 2009
David Levin <levin at chromium.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 28962: Remove unnecessary dependency on unistd.h in Completion.cpp
https://bugs.webkit.org/show_bug.cgi?id=28962
Attachment 39032: the patch
https://bugs.webkit.org/attachment.cgi?id=39032&action=review
------- Additional Comments from David Levin <levin at chromium.org>
r=me with one small fix below.
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> + https://bugs.webkit.org/show_bug.cgi?id=(OOPS!)
Please fill in the bug number when landing.
It appears that this include was added for
http://bugs.webkit.org/show_bug.cgi?id=17339 due to the use of getpid() in this
file but that function call is no longer present.
More information about the webkit-reviews
mailing list