[webkit-reviews] review denied: [Bug 28038] WebSocket API implementation : [Attachment 38963] WebSocket API implementation

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 28038: WebSocket API implementation
https://bugs.webkit.org/show_bug.cgi?id=28038

Attachment 38963: WebSocket API implementation
https://bugs.webkit.org/attachment.cgi?id=38963&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   OwnPtr<char> m_buffer;
> +	   int m_bufferSize;

The buffer is allocated with tryFastMalloc, but freed with delete, which will
cause problems on some configurations - in debug mode, it will be allocated
with malloc, but freed with delete. OwnPtr is not suitable for holding arrays
of data, I think that you may need to work with plain pointers here.

I should have noticed this earlier, sorry!