[webkit-reviews] review granted: [Bug 28911] WebInspector: serialize calls to InjectedScript with JSON. : [Attachment 38929] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 13:09:46 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 28911: WebInspector: serialize calls to InjectedScript with JSON.
https://bugs.webkit.org/show_bug.cgi?id=28911

Attachment 38929: patch
https://bugs.webkit.org/attachment.cgi?id=38929&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    ScriptValue callFrames = function.call();
> +    return callFrames.toString(m_inspectorController->m_scriptState);

I think callFrames is a copy-and-paste error. This should have a different
name.

I see the light at the end of the tunnel!


More information about the webkit-reviews mailing list