[webkit-reviews] review denied: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 34655] Optimize the QWebPluginInfo::mimeTypes() function.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 12:13:12 PDT 2009


Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 34655: Optimize the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/attachment.cgi?id=34655&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Hmm, wouldn't it be better to do this on-demand by having m_mimeTypes mutable?
Otherwise it becomes much more expensive to construct a QWebPluginInfo object
even if you never call mimeTypes() on it?


More information about the webkit-reviews mailing list