[webkit-reviews] review denied: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 34653] Remove the private classes from QWebPluginDatabase.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 12:08:11 PDT 2009


Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 34653: Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/attachment.cgi?id=34653&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Jakub, the patch looks great to me, except for one _tiny_ buglet. I'll r+ it if
you
could leave the d pointers in there. Add the m_plugin, m_database, etc.
members, that's
great. But keep the (forward declared) d-pointers, too, even if they're unused.
_If_ 
something goes wrong we can still extend with the d-pointer and keep binary
compatibility.

Sorry :)


More information about the webkit-reviews mailing list