[webkit-reviews] review denied: [Bug 28884] Add CreateRequestExtension to QWebPage : [Attachment 38880] Update patch to add missing doc
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 3 12:01:09 PDT 2009
Simon Hausmann <hausmann at webkit.org> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 28884: Add CreateRequestExtension to QWebPage
https://bugs.webkit.org/show_bug.cgi?id=28884
Attachment 38880: Update patch to add missing doc
https://bugs.webkit.org/attachment.cgi?id=38880&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I understand what you're trying to achieve (through earlier emails), but I
don't understand who this extension helps you to be able to track the
originating frame of a QNetworkRequest if nothing in WebCore/WebKit actually
call this function. The documentation also doesn't explain what I'm wondering
about:
* What's the use of the output value?
* Why does it have to be filled out?
Usually the extension pattern is used to allow developers to change existing
behaviour where we would normally add a new virtual function but cannot because
of binary compatibility constraints.
Perhaps all you need is a signal that is emitted whenever a request is created?
:)
Perhaps the request callbacks in FrameLoaderClientQt.cpp could be the source
that triggers the API?
More information about the webkit-reviews
mailing list