[webkit-reviews] review denied: [Bug 25930] Mismatched free : [Attachment 38980] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 25930: Mismatched free
https://bugs.webkit.org/show_bug.cgi?id=25930

Attachment 38980: proposed patch
https://bugs.webkit.org/attachment.cgi?id=38980&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This may quiet valgrind, but it doesn't solve the problem.

There's still a mismatch. The allocation is fastNew of a CSSSelector and the
deallocation is fastDelete of a char. The fact that this currently works
doesn't mean it's matched up.

This also introduces a new mismatch, between the fastNew in
CSSParser::createFloatingSelector() and the delete done by the call to
deleteAllValues in ~CSSParser. If we change to fastNew we need to change the
delete to fastDelete.

The usage should be just fastDelete, not WTF::fastDelete.

---

We could add a variant of fastDelete that does not call a destructor, and fix
the mismatch that way. There may be some other good solution.