[webkit-reviews] review requested: [Bug 28938] CSS string value is not correctly serialized when it contains binary characters : [Attachment 38979] Escape control characters in CSS string value when it is serialized.

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has asked  for review:
Bug 28938: CSS string value is not correctly serialized when it contains binary
characters
https://bugs.webkit.org/show_bug.cgi?id=28938

Attachment 38979: Escape control characters in CSS string value when it is
serialized.
https://bugs.webkit.org/attachment.cgi?id=38979&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
When WebKit serializesa CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts, which was not good.
This change fixes this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (escapeCSSString).
---
 7 files changed, 185 insertions(+), 52 deletions(-)