[webkit-reviews] review requested: [Bug 25253] REGRESSION: 'maxLength' of input text field doesn't work for CJK characters : [Attachment 38974] Proposed patch (rev.4)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 25253: REGRESSION: 'maxLength' of input text field doesn't work for CJK
characters
https://bugs.webkit.org/show_bug.cgi?id=25253

Attachment 38974: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=38974&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
> These tests look like they can be dumpAsText() tests.  That's much preferred
> over render tree dump tests.

dumpAsText() didn't show text in <input>.
Bono-san gave me an advice of using document.getSelection().  I have updated
the tests for document.getSelection().

> Why do we need to pass Document* now that we're passing Element*?  you can
get
> element->document(). :)

That's right.  I removed the Document* parameter.