[webkit-reviews] review denied: [Bug 28936] Allow [Reflect] on SVG elements : [Attachment 38970] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 01:25:05 PDT 2009


Eric Seidel <eric at webkit.org> has denied Cameron McCormack <cam at mcc.id.au>'s
request for review:
Bug 28936: Allow [Reflect] on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=28936

Attachment 38970: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38970&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
In general this looks fine.

I would like to see a real example use this.  Since I think it makes sense to
convert one attribute as a test and make that part of this patch.

Also, some SVG attributes, like "class" come from HTMLNames.  We probably need
a fallback behavior on a per-name basis, instead of a idl-level decision.  All
SVG and HTML attributes are in the null namespace, so it doesn't really matter
which we're using so long as it has the name we're looking for.


More information about the webkit-reviews mailing list