[webkit-reviews] review denied: [Bug 27787] The type information about the resource loading is not forwarded to the network layer : [Attachment 34879] new version of the patch, with changelog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Zsombor <gzsombor at gmail.com>'s request
for review:
Bug 27787: The type information about the resource loading is not forwarded to
the network layer
https://bugs.webkit.org/show_bug.cgi?id=27787

Attachment 34879: new version of the patch, with changelog
https://bugs.webkit.org/attachment.cgi?id=34879&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
In general this looks good!

Please remove this:
42     default:
 243	      return Other;
and put a "return Other" after the switch.  See my previous comment about
default: cases for switches over enums as being bad. :)

We could avoid all this search/replace by adding a typedef
ResourceRequestBase::Type Type; into CachedResponse.  I'm not sure I really
care one way or the other, but it would definitely make the patch smaller.

Style:
 45	case ResourceRequestBase::ImageResource :
(no space after value before ':')

Otherwise looks good.