[webkit-reviews] review denied: [Bug 13631] Page Cache should support pages with frames : [Attachment 38951] Almost there...

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 13631: Page Cache should support pages with frames
https://bugs.webkit.org/show_bug.cgi?id=13631

Attachment 38951: Almost there...
https://bugs.webkit.org/attachment.cgi?id=38951&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Should use an enum instead of adding a new bool argument.

It's true that in one place the argument is a boolean expression, not a
constant, but I still think that these confusing functions can be made less so
with enums.

In fact, I think you could combine the sendUnload and sendPagehide bool
arguments into a single enum if you name the values carefully.