[webkit-reviews] review requested: [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit : [Attachment 38927] Fixed style issues

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 09:01:24 PDT 2009


Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 23291: -webkit-box-shadow doesn't work on Qt-WebKit
https://bugs.webkit.org/show_bug.cgi?id=23291

Attachment 38927: Fixed style issues
https://bugs.webkit.org/attachment.cgi?id=38927&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
Unfortunately, after fixing indenting, the svn-create-patch tool created a
counterintuitive patch that makes it look like much more is changed than it
actually has around the fillRect function. Carefull examination will show that
essentially what has been done here is that the shadow drawing has been
extracted from the function into a separate function placed before it in the
code.


More information about the webkit-reviews mailing list