[webkit-reviews] review denied: [Bug 28781] Add QWebFrame::renderElement to API : [Attachment 38748] QWebElement::render API implementation

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 28781: Add QWebFrame::renderElement to API
https://bugs.webkit.org/show_bug.cgi?id=28781

Attachment 38748: QWebElement::render API implementation
https://bugs.webkit.org/attachment.cgi?id=38748&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
> +void QWebElement::render(QPainter *painter)

Need docs

> +    Frame* fr = doc->frame();

Style, use meaningful variable names.

> +    if ( !fr || !fr->view() || !fr->contentRenderer())
> +	   return;
> +
> +    IntRect p_rect = e->getRect();

Same as above + camelCase, not _

Goes for all of the variables in the method.

> +    void render(QPainter *painter);

Need autotest