[webkit-reviews] review requested: [Bug 28907] [Qt] The --strict switch of run-webkit-tests does not work : [Attachment 38922] Implement --without-metrics switch for the Qt port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 04:36:34 PDT 2009


Andras Becsi <becsi.andras at stud.u-szeged.hu> has asked Ariya Hidayat
<ariya.hidayat at trolltech.com> for review:
Bug 28907: [Qt] The --strict switch of run-webkit-tests does not work
https://bugs.webkit.org/show_bug.cgi?id=28907

Attachment 38922: Implement --without-metrics switch for the Qt port
https://bugs.webkit.org/attachment.cgi?id=38922&action=review

------- Additional Comments from Andras Becsi <becsi.andras at stud.u-szeged.hu>
Using run-webkit-tests --strict on the Qt port should compare the mac expected
files with the actual files of the Qt port with the font size metrics removed
from the files. In this way only the render tree is compared and so the obvious
differences can be tracked, and the related bugs can be corrected.

The attached patch completes and corrects the implementation of --strict and
renames the switch to --without-metrics.


More information about the webkit-reviews mailing list