[webkit-reviews] review requested: [Bug 9589] WCSS: -wap-accesskey not supported : [Attachment 38919] new patch address reviewer's comments

[bugzilla-daemon at webkit.org]

Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 9589: WCSS: -wap-accesskey not supported
https://bugs.webkit.org/show_bug.cgi?id=9589

Attachment 38919: new patch address reviewer's comments
https://bugs.webkit.org/attachment.cgi?id=38919&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch addresses the following comments by the reviewer:
1. style issue
2. spelling issue
3. Spacing issue 
4. use m_elementsByAccessKey strategy to store the [accesskey, element] pair in
m_elementsByAccessKey , this is done only once	 for a document, next time you
have a accesskey pressed,  it will try to get the element from
m_elementsByAccessKey directly instead tranversing the DOM.
   To do that , m_elementsByAccessKey was changed 
  from :
    mutable HashMap<StringImpl*, Element*, CaseFoldingHash>
m_elementsByAccessKey;
  to: 
    mutalbe HashMap<String, Element*, CaseFoldingHash> m_elementsByAccessKey;

   because we can't hold a StringImpl* since the accesskey in the style sheet,
while before the change,  the index of m_elementsByAccessKey is of type
"StringImpl*", which is hold by an element in it's "accesskey" attribute .

5.  As to the mention of "querySelector would answer the CSS side of the
question" , I don't know how to apply that to this feature.  basically what we
would like to do is to go through all elements and find those with
"-wap-accesskey" style or with "accesskey" attribute,  if an element with both
"accesskey" attribute and "-wap-accesskey" style applied, the -wap-accesskey
takes precedence .

To address the reviewer's other comments: 

 "why this obscure part of a dying spec is needed",  actually WCSS is an
emergying spec instead of a dying spec, which is initiatied by OMA, an big
player in Mobile industry, for Mobile devides. OMA standard compliance is a
requirement of must for many operators and device manufactures,  implementation
of WCSS and other OMA specs in WebKit definitely promotes WebKit into a wider
spectrum of devices.