[webkit-reviews] review granted: [Bug 27099] Elements with display none still gets focus and take part in the tab order : [Attachment 38708] Eric's comments taken care of

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 38708: Eric's comments taken care of
https://bugs.webkit.org/attachment.cgi?id=38708&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine to me.

I'm assuming the blur event count change is intentional:
-335 focus / 335 blur events disatched, and should be 335 / 335 PASSED
+329 focus / 329 blur events dispatched, and should be 335 / 335 PASSED

A comment here would have problem helped:
-bool HTMLFrameElementBase::isFocusable() const
+bool HTMLFrameElementBase::supportsFocus() const
 {
-    return renderer();
+    return true;
 }

This is OK as is.