[webkit-reviews] review denied: [Bug 23865] Safari can be frozen by rapidly adding timers : [Attachment 38364] Path to fix UI freeze on long timer queue.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 16:25:43 PDT 2009


Adam Barth <abarth at webkit.org> has denied Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 23865: Safari can be frozen by rapidly adding timers
https://bugs.webkit.org/show_bug.cgi?id=23865

Attachment 38364: Path to fix UI freeze on long timer queue.
https://bugs.webkit.org/attachment.cgi?id=38364&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ static const int maxDurationOfFiringTimers = 0.050;

This code makes no sense.  This will just get rounded to zero.

Also, can we write a test for this?  Maybe have DRT queue up an event while
firing a lot of timers?


More information about the webkit-reviews mailing list