[webkit-reviews] review requested: [Bug 28877] Implement bugzilla-tool mark-fixed : [Attachment 38867] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 09:42:10 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 28877: Implement bugzilla-tool mark-fixed
https://bugs.webkit.org/show_bug.cgi?id=28877

Attachment 38867: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38867&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

The mark-fixed subcommand is for those times when you don't use
bugzilla-tool to commit a patch, but you want to use it to close
the bug with a committed-revision message.

* Scripts/bugzilla-tool:
(bug_comment_from_svn_revision): Added.  Extracted from
bug_comment_from_commit_text().
(bug_comment_from_commit_text): Extracted
bug_comment_from_svn_revision() from this method.
(MarkBugFixed.__init__): Added.
(MarkBugFixed._determine_bug_id_and_svn_revision): Added.
Attempts to use bug id and svn revision passed in from the
command-line, but falls back to checking the last svn commit log
if either isn't defined.
(MarkBugFixed.execute): Added.	Adds a comment about the
revision that fixed the bug and closes the bug.
(BugzillaTool.__init__): Added mark-fixed subcommand.
* Scripts/modules/bugzilla.py:
(Bugzilla.fetch_title_from_bug): Added.
* Scripts/modules/scm.py:
(SCM.last_svn_commit_log): Added.  Subclasses must override.
(SVN.last_svn_commit_log): Added.  Uses svnversion to find the
last commit in an svn working directory and then runs svn log.
(Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
of one log message.
---
 4 files changed, 115 insertions(+), 2 deletions(-)


More information about the webkit-reviews mailing list