[webkit-reviews] review denied: [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") : [Attachment 38804] patch: layout test for getData("text/uri-list")

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 09:32:39 PDT 2009


David Levin <levin at chromium.org> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 28293: [Chromium] event.datatransfer.getdata("text/uri-list") treated the
same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Attachment 38804: patch: layout test for getData("text/uri-list")
https://bugs.webkit.org/attachment.cgi?id=38804&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for this: The skipped files still refer to the old test location.

Personally I would still prefer this layout tests to be with the patch for the
bug.  Even though it currently doesn't test chromium due to the layout test
controller support that needs to be added, it will test the patch when that
support is added shortly.

Lastly, I would clean up the changelog some (e.g. "var" isn't a function).


As a note to other readers, the name of the test doesn't seem to fit the
pattern of other test names, but with layout tests non-uniformity of this sort
is good to actually test WebKit better.


More information about the webkit-reviews mailing list