[webkit-reviews] review granted: [Bug 28831] Make ElementTimeControl methods return void and not throw : [Attachment 38852] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 08:07:06 PDT 2009


Eric Seidel <eric at webkit.org> has granted Cameron McCormack <cam at mcc.id.au>'s
request for review:
Bug 28831: Make ElementTimeControl methods return void and not throw
https://bugs.webkit.org/show_bug.cgi?id=28831

Attachment 38852: Patch v2
https://bugs.webkit.org/attachment.cgi?id=38852&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  I generally write SVG tests as DOM-only tests and just add an
iframe with teh SVG content.  But what you've done is also totally fine. :)  We
really should make the js testing framework smart enough to handle a
TEMPLATE.svg file as well.


More information about the webkit-reviews mailing list