[webkit-reviews] review requested: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 38861] Join the various PluginView destructors into one shared implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 1 05:20:08 PDT 2009
Tor Arne Vestbø <vestbo at webkit.org> has asked for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706
Attachment 38861: Join the various PluginView destructors into one shared
implementation
https://bugs.webkit.org/attachment.cgi?id=38861&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
https://bugs.webkit.org/show_bug.cgi?id=27706
The Qt port used to delete the platform plugin widget as the last step.
Now this is done before cleaning up the script objects and unloading the
plugin package, similar to how the Win port does it.
* plugins/PluginView.cpp:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
7 files changed, 78 insertions(+), 101 deletions(-)
More information about the webkit-reviews
mailing list