[webkit-reviews] review requested: [Bug 30980] Cleanup in wx code: avoid unnecessary wxString::mb_str() calls : [Attachment 42258] Patch removing unnecessary wxString::mb_str() calls

[bugzilla-daemon at webkit.org]

Vadim Zeitlin <vz-webkit at zeitlins.org> has asked  for review:
Bug 30980: Cleanup in wx code: avoid unnecessary wxString::mb_str() calls
https://bugs.webkit.org/show_bug.cgi?id=30980

Attachment 42258: Patch removing unnecessary wxString::mb_str() calls
https://bugs.webkit.org/attachment.cgi?id=42258&action=review

------- Additional Comments from Vadim Zeitlin <vz-webkit at zeitlins.org>
While debugging the bug 30977 I noticed that in a few places in the code there
were ugly-looking explicit conversions between wxString and WebCore::String.
They seem to be unnecessary as there is already an implicit ctor in String from
wxString so IMO we should be simply using it because just "baseUrl" looks much
better than "static_cast<const char*>(baseUrl.mb_str(wxConvUTF8))". So I attach
a patch which simply removes these calls.