[webkit-reviews] review granted: [Bug 30942] Use pointers instead of copies to pass GregorianDateTime objects around : [Attachment 42235] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 30 14:46:08 PDT 2009
Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 30942: Use pointers instead of copies to pass GregorianDateTime objects
around
https://bugs.webkit.org/show_bug.cgi?id=30942
Attachment 42235: patch2
https://bugs.webkit.org/attachment.cgi?id=42235&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
r=me
Generally we should never be typing "WTF::" anywhere except for the "using
WTF::<name>" in the WTF headers. It looks like we’re not following that
guideline (created by Maciej) in the code you’re modifying or the code you’re
adding.
More information about the webkit-reviews
mailing list