[webkit-reviews] review requested: [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement : [Attachment 42233] Patch

[bugzilla-daemon at webkit.org]

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 29972: Implement URL decomposition IDL attributes for HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=29972

Attachment 42233: Patch
https://bugs.webkit.org/attachment.cgi?id=42233&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Thank you for the review, Darin.
This updated patch takes your comments into account. I changed the test result
of local file to expect "FAIL" instead of "PASS", we should revisit that in a
separate patch. As a side note, IE and FF do recognize c:/ as a local file, but
do not recognize c:\ as a local file. My implementation was doing the same.

I was not sure where to publish the compatibility list. In general, I always
tried to match IE, and if IE threw an exception, then I tried to match FF.

One test case (line 23) in fast/loader/url-parse-1.html is failing with my
patch. It expects that we always add '/' if the path is empty, but we should
only add that if the URL is hierarchical. (IE8 does not add that)
Should I change the expected result in the same patch, or as a follow-up?

thanks, Yael