[webkit-reviews] review granted: [Bug 30941] Refactor DatabaseTask in preparation for removing threadsafe refcounting from it : [Attachment 42218] Updated patch.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 30941: Refactor DatabaseTask in preparation for removing threadsafe
refcounting from it
https://bugs.webkit.org/show_bug.cgi?id=30941

Attachment 42218: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=42218&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few nits to address on check in.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   (WebCore::DatabaseTask::DatabaseTask): Ctor takes
DatabaseTaskSynchronizer which can be NULL.

Use 0 instead of NULL (since NULL isn't used in the code).

> diff --git a/WebCore/storage/Database.h b/WebCore/storage/Database.h


> @@ -56,43 +78,19 @@ void DatabaseTask::performTask()
> +    if(m_synchronizer)

add space after if.


> diff --git a/WebCore/storage/DatabaseTask.h b/WebCore/storage/DatabaseTask.h
> +    static PassRefPtr<DatabaseOpenTask> create(Database* db,
DatabaseTaskSynchronizer* synchronizer, ExceptionCode& code, bool& success) {

brace position.

> +    static PassRefPtr<DatabaseTransactionTask>
create(PassRefPtr<SQLTransaction> transaction) {

brace position.

> +    static PassRefPtr<DatabaseTableNamesTask> create(Database* db,
DatabaseTaskSynchronizer* synchronizer, Vector<String>& names) {

brace position.

There are several more functions with bad brace placement as well.