[webkit-reviews] review denied: [Bug 30674] Failed on test case: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm : [Attachment 42222] fix patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 30674: Failed on test case:
http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e
.htm
https://bugs.webkit.org/show_bug.cgi?id=30674

Attachment 42222: fix patch
https://bugs.webkit.org/attachment.cgi?id=42222&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This only patches the Qt-specific code path, not the normal
platform-independent one. It’s also not the best practice to post a patch
knowingly leaving out the test you plan to make. It creates more work for
reviewers who have to review it twice even if there’s nothing wrong with it.
It’s better engineering to write the test before the bug fix -- you need to
make sure it fails without the code change.