[webkit-reviews] review granted: [Bug 30409] Need to turn off notifications properly at runtime : [Attachment 42219] new patch for the new way

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted John Gregg <johnnyg at google.com>'s
request for review:
Bug 30409: Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409

Attachment 42219: new patch for the new way 
https://bugs.webkit.org/attachment.cgi?id=42219&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bindings/v8/RuntimeEnabledFeatures.h
> +    static bool isNotificationsEnabled;

Hmmm, this should have been m_ since these are class members but I see you're
following a pattern.

> Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
> +    return WebCore::RuntimeEnabledFeatures::notificationsEnabled();

Since the code is in namespace WebCore, WebCore:: isn't needed.


> Index: WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp
> +    return WebCore::RuntimeEnabledFeatures::notificationsEnabled();

Since the code is in namespace WebCore, WebCore:: isn't needed.


Just remove the WebCore:: from the two places mentioned on landing.