[webkit-reviews] review denied: [Bug 30955] REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line : [Attachment 42215] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 30955: REGRESSION: In Mail, Undo does not restore some characters I have
deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955

Attachment 42215: Patch
https://bugs.webkit.org/attachment.cgi?id=42215&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    if (isOpenForMoreTypingCommand(lastEditCommand)) {
> +    if (!killRing && isOpenForMoreTypingCommand(lastEditCommand)) {

It's not correct to use the killRing boolean for this. That has a specific
meaning, and it just happens to be set in the appropriate cases. I would like
to see a new patch that does this in some logically consistent way.

One possibility would be to continue to use this boolean and rename it to
reflect its new meaning.

Another possibility would be to add some other argument or mechanism for
controlling whether new keys are added to the existing typing.