[webkit-reviews] review requested: [Bug 15914] [GTK] Implement Unicode functionality using GLib : [Attachment 42210] 2/4 - Moving Text Codecs to GLib (v4)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 30 06:35:19 PDT 2009
Dominik Röttsches <dominik.roettsches at access-company.com> has asked for
review:
Bug 15914: [GTK] Implement Unicode functionality using GLib
https://bugs.webkit.org/show_bug.cgi?id=15914
Attachment 42210: 2/4 - Moving Text Codecs to GLib (v4)
https://bugs.webkit.org/attachment.cgi?id=42210&action=review
------- Additional Comments from Dominik Röttsches
<dominik.roettsches at access-company.com>
(In reply to comment #88)
> Regarding this, there's an exception to the camel case rule for acronyms, and
> indeed all usages of "utf" in this file seem to be upper-cased, so I think we
> should strive for consistency. This seems to be the only problem I am able to
> spot by now. Sorry for being nit-picky, but please upload a patch with this
> fixed so that we can use the commit queue =). Thanks!
Sure, here it is. Thanks for reviewing.
More information about the webkit-reviews
mailing list