[webkit-reviews] review granted: [Bug 30948] Regression: crash enumerating properties of an object with getters or setters : [Attachment 42180] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 01:10:35 PDT 2009


Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 30948: Regression: crash enumerating properties of an object with getters
or setters
https://bugs.webkit.org/show_bug.cgi?id=30948

Attachment 42180: Patch v1
https://bugs.webkit.org/attachment.cgi?id=42180&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
In the über-big if statement, I have a feeling we usually put the && on the
continuing line.  Also, might be nicer with one line per clause.
Still, r+ with or without that change.


More information about the webkit-reviews mailing list