[webkit-reviews] review denied: [Bug 30832] Notify the chrome when the focused node has changed. : [Attachment 42121] more fixes

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 30832: Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832

Attachment 42121: more fixes
https://bugs.webkit.org/attachment.cgi?id=42121&action=review

------- Additional Comments from David Levin <levin at chromium.org>
My only concern is that this will break the builds for non-chromium clients.

I think the easiest way to handle this is to not make this function pure  
   "virtual void focusedNodeChanged(Node*) = 0" 
but I would recommend against this.

The very nice thing about pure methods is that they help ports to quick realize
when they got broken by a parameter being added/changed/etc.

So instead it would be *much better* to find each class that derives from
ChromeClient and given them a default implementation that does nothing.

With this last change, I think this will be ready to go in.