[webkit-reviews] review granted: [Bug 30937] MSAA: Accessibility of headings is not correct : [Attachment 42167] patch

[bugzilla-daemon at webkit.org]

Alice Liu <alice.liu at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 30937: MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937

Attachment 42167: patch
https://bugs.webkit.org/attachment.cgi?id=42167&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
> +String AccessibilityRenderObject::stringRoleForMSAA() const
> +{
...
> +    // FIXME: Add the other tag names that should be returned as the role.
> +    Element* element = static_cast<Element*>(node);
> +    if (element->hasTagName(h1Tag) || element->hasTagName(h2Tag) ||
> +	   element->hasTagName(h3Tag) || element->hasTagName(h4Tag) ||
> +	   element->hasTagName(h5Tag) || element->hasTagName(h6Tag))
> +	   return element->tagName();
> +
> +    return String();
> +}

I saw the list of remaining ones, and there aren't that many, so i would
suggest just adding them.  Factoring out the tag name check into a static
function would make for more organized code, especially when you add the
missing ones. 

r=me