[webkit-reviews] review granted: [Bug 26856] AnchorElement, ButtonElement, InputButton and Document should fire focus event when it is clicked. : [Attachment 42159] Fixed issues with tabIndex and contentEditable and expanded the tests to cover these

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 26856: AnchorElement, ButtonElement, InputButton and Document should fire
focus event when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=26856

Attachment 42159: Fixed issues with tabIndex and contentEditable and expanded
the tests to cover these
https://bugs.webkit.org/attachment.cgi?id=42159&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's a bit strange to see this in the results:
 Anchor with tab index
 6 
 7 Anchor without tab index
 8 
 9 Link without tab index
 10 
 11 Link with tab index
 12 
 13 Link with contentEditable
 14 
 15 Link inside contentEditable

it's just noise.  For bonus points you could wrap it in a div and hwne running
under DRT remove it at the end of the test.

 74	    // Make sure that links with tabIndex or contentEditable are still
focusable.

Maybe something more like: // Only allow links with a tabIndex or
contentEditable to be mouse-focusuable.

the "make sure" comment only makes sense given the previous code. :)

In general this looks fine though.