[webkit-reviews] review granted: [Bug 30928] MSAA: Accessibility of links is wrong : [Attachment 42153] patch v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 30928: MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928

Attachment 42153: patch v2
https://bugs.webkit.org/attachment.cgi?id=42153&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
What about my <area> comment? You're checking specifically for the <a> tag, but
<area> are also derived from HTMLAnchorElement.

> +    if (m_renderer && m_renderer->isText())
> +	   return static_cast<RenderText*>(m_renderer)->text();

Is this really right? This won't take things like whitespace-collapsing into
account. Lets investigate that further at some point.

r=me