[webkit-reviews] review denied: [Bug 30928] MSAA: Accessibility of links is wrong : [Attachment 42145] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 29 14:29:06 PDT 2009

Darin Adler <darin at apple.com> has denied Jon Honeycutt <jhoneycutt at apple.com>'s
request for review:
Bug 30928: MSAA: Accessibility of links is wrong

Attachment 42145: patch

------- Additional Comments from Darin Adler <darin at apple.com>
> +    virtual String stringValueForMSAA() const { return String(); }
> +    virtual String nameForMSAA() const { return String(); }
> +#endif

Thanks for taking my suggestion of putting these here in this class instead of
just in the Windows AccessibleBase. I also think they can be included
unconditionally, even though the code won't be called on other platforms.

> +++ b/WebCore/accessibility/win/AccessibilityRenderObjectWin.cpp

Please take my suggestion above and thus don't add a new source file.

> +	   Element* anchor = anchorElement();
> +	   if (anchor && anchor->hasTagName(aTag))
> +	       return static_cast<HTMLAnchorElement*>(anchor)->href();

Not all HTMLAnchorElement are <a> tags. It would be good to handle <area> too.

Otherwise looks good to me.

review- so you can consider my suggested approach of putting this code in
cross-platform source files

More information about the webkit-reviews mailing list