[webkit-reviews] review requested: [Bug 30144] MIPS JIT Supports : [Attachment 42114] MIPS JIT Patch 20091029

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 29 11:04:51 PDT 2009


Chao-ying Fu <fu at mips.com> has asked  for review:
Bug 30144: MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

Attachment 42114: MIPS JIT Patch 20091029
https://bugs.webkit.org/attachment.cgi?id=42114&action=review

------- Additional Comments from Chao-ying Fu <fu at mips.com>
I updated the patch based on the review to remove redundant comments
and to use loadDelayNop() and copDelayNop().

Other changes in this patch:
1. For __clear_cache, we test (GCC_VERSION < 40500) to perform the workaround.
Since GCC 4.5 has the fix for MIPS, we don't need the workaround.

2. In linkWithOffset, we check "*(insn + 2) != 0x10000003" to generate j or
lui/ori/jr
for correctness.

3. Extra () are removed.


More information about the webkit-reviews mailing list