[webkit-reviews] review requested: [Bug 30904] [v8] Missing IsEmpty() check in V8Proxy::sourceName() : [Attachment 42110] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 29 10:43:08 PDT 2009


Yury Semikhatsky <yurys at chromium.org> has asked  for review:
Bug 30904: [v8] Missing IsEmpty() check in V8Proxy::sourceName()
https://bugs.webkit.org/show_bug.cgi?id=30904

Attachment 42110: patch
https://bugs.webkit.org/attachment.cgi?id=42110&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
I would like to add a layout test for this patch but it needs to overflow
JavaScript stack and takes for about 30 seconds to complete on my machine. I'm
going to provide some means for setting JavaScript stack limit from layout
tests first and after that commit the test case itself. I'll post the patch
with the long running test case a bit later in a separate patch so that you can
see what I'm talking about.

Since the patch is fixing one of the most frequent current Chromium crashes I'd
prefer to submit it sooner and add the test later.


More information about the webkit-reviews mailing list