[webkit-reviews] review denied: [Bug 30902] Need a layout test for Bug 28284 : [Attachment 42089] A simple layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 29 08:23:26 PDT 2009
Darin Adler <darin at apple.com> has denied Hironori Bono <hbono at chromium.org>'s
request for review:
Bug 30902: Need a layout test for Bug 28284
https://bugs.webkit.org/show_bug.cgi?id=30902
Attachment 42089: A simple layout test
https://bugs.webkit.org/attachment.cgi?id=42089&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Putting a patch up for review that is just a test is fine.
> + // Insert a Thai character U+0E01.
> + eventSender.keyDown(String.fromCharCode(0x0E01));
I believe there is a way to make this test work without using eventSender. See,
for example, events/option-tab.html and forms/input-text-enter.html which
create a keyboard event using the DOM.
Please make a version that does not use eventSender, or explain why not.
Otherwise, this test looks very good to me.
More information about the webkit-reviews
mailing list