[webkit-reviews] review canceled: [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface : [Attachment 41963] Table 2 - Adjusted to address compiler warning about comparing signed and unsigned

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has canceled Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25534: [GTK] Objects of ROLE_TABLE should implement the accessible table
interface
https://bugs.webkit.org/show_bug.cgi?id=25534

Attachment 41963: Table 2 - Adjusted to address compiler warning about
comparing signed and unsigned
https://bugs.webkit.org/attachment.cgi?id=41963&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
(In reply to comment #21)
> (From update of attachment 41963 [details])
> >	 AccessibilityTableCell* AXCell = cell(table, row, column);
> 
> One minor nit: this should be axCell.

Ok. Given that it's in existing code and not added by this patch, I left that
particular one alone. Hope that's ok!(?) But I've already promised Xan I'd go
through the Atk a11y stuff with a lint brush. My current list is:

* Trailing whitespace
* NULL
* AXFoo should be axFoo

Bug 30901 has just been created so y'all can add to the list. :-)

> > +static gint webkit_accessible_table_get_column_at_index(AtkTable* table,
gint index)
> > +{
> > +	 AccessibilityTableCell* AXCell = cellAtIndex(table, index);
> 
> Ditto.

Changed.

Thanks!