[webkit-reviews] review requested: [Bug 30888] Implementation of String.quote() method : [Attachment 42065] Implementation of String.quote() method

[bugzilla-daemon at webkit.org]

Ioseb Dzmanashvili <ioseb.dzmanashvili at gmail.com> has asked  for review:
Bug 30888: Implementation of String.quote() method
https://bugs.webkit.org/show_bug.cgi?id=30888

Attachment 42065: Implementation of String.quote() method
https://bugs.webkit.org/attachment.cgi?id=42065&action=review

------- Additional Comments from Ioseb Dzmanashvili
<ioseb.dzmanashvili at gmail.com>
Hi all,

I've just implemented String.quote() method based on Mozilla's implementation:
https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Global_Objects/S
tring

Actually this is not standard feature, but as far as it is often very useful to
quote strings with this method and Mozilla already implemented it.

While trying to implement this method I found that there is code in JSON module
that implements string quoting method but was not public. I moved this method
to "JSGlobalObjectFunctions.cpp" (see "quoteString()" function) and changed
JSON method to invoke this global function. "quote()" method uses this global
function as well... 

Implementation and test cases are included in patch.

Regards,
Ioseb