[webkit-reviews] review denied: [Bug 30721] [GTK] DRT reports error in the wrong test : [Attachment 41855] Proposed patch moving the flush to the end of the test

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 30721: [GTK] DRT reports error in the wrong test
https://bugs.webkit.org/show_bug.cgi?id=30721

Attachment 41855: Proposed patch moving the flush to the end of the test
https://bugs.webkit.org/attachment.cgi?id=41855&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Chromium recently had similar troubles.  I still think putting this in some
nicely named function would make this much clearer.  As-is, if we ever need to
modify the "test shut down" procedure, it's difficult to tell where it is or
what all of the code should be moved were this ever to move again.  r- because
I really think this needs to be put in a function with a nice name and called
from this runTests() location.

sendPixelResultsEOF() or something even more descriptive?