[webkit-reviews] review granted: [Bug 30122] Geolocation does not protect against wrap-around of request IDs : [Attachment 42043] Patch 1 for Bug 30122

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 10:49:28 PDT 2009


Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 30122: Geolocation does not protect against wrap-around of request IDs
https://bugs.webkit.org/show_bug.cgi?id=30122

Attachment 42043: Patch 1 for Bug 30122
https://bugs.webkit.org/attachment.cgi?id=42043&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

If you want to be pedantic, overflow has defined behavior for unsigned but not
for int. So it's best to code this sort of thing so it detects overflow before
it happens or use unsigned. But that's not a realistic concern.


More information about the webkit-reviews mailing list