[webkit-reviews] review granted: [Bug 30866] Web Inspector: Add InspectorController stub in order to support opening in standalone mode. : [Attachment 42035] [PATCH] stub
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 28 09:35:36 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30866: Web Inspector: Add InspectorController stub in order to support
opening in standalone mode.
https://bugs.webkit.org/show_bug.cgi?id=30866
Attachment 42035: [PATCH] stub
https://bugs.webkit.org/attachment.cgi?id=42035&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + <script type="text/javascript"
src="InspectorControllerStub.js"></script>
This should probably be added first.
> + this._windowVisible = false;
> + this._searchingForNode = !this._searchingForNode;
Bad indents here.
> + wrapCallback: function f(func)
Why name this function "f"?
More information about the webkit-reviews
mailing list