[webkit-reviews] review denied: [Bug 30861] WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag processing : [Attachment 42031] WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied  review:
Bug 30861: WebInspector: Adds InspectorTimelineAgent instrumentation for
<script> tag processing
https://bugs.webkit.org/show_bug.cgi?id=30861

Attachment 42031: WebInspector: Adds instrumentation of the script tag, and
getters to ScriptSourceCode
https://bugs.webkit.org/attachment.cgi?id=42031&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   timelineAgent->willScriptTag(sourceCode.url().isNull() ? String() :
sourceCode.url().string(), sourceCode.startLine());
> +	   timelineAgent->didScriptTag();
> +	   ScriptTagTimelineRecordType = 10,

The wording is weird here. Would be better as
willEvaluateScriptTag/didEvaluateScriptTag/EvaluateScriptTagTimelineRecordType.


Otherwise r+.