[webkit-reviews] review denied: [Bug 15914] [GTK] Implement Unicode functionality using GLib : [Attachment 41866] 2/4 - Moving Text Codecs to GLib (v3)

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Dominik Röttsches
<dominik.roettsches at access-company.com>'s request for review:
Bug 15914: [GTK] Implement Unicode functionality using GLib
https://bugs.webkit.org/show_bug.cgi?id=15914

Attachment 41866: 2/4 - Moving Text Codecs to GLib (v3)
https://bugs.webkit.org/attachment.cgi?id=41866&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +#elif USE(GLIB_UNICODE)
> +    GOwnPtr<char> utf8Source;
> +    utf8Source.set(g_utf16_to_utf8(characters, length, 0, 0, 0));
> +
> +    GOwnPtr<char> utf8Normalized;
> +    utf8Normalized.set(g_utf8_normalize(utf8Source.get(), -1,
G_NORMALIZE_NFC));
> +
> +    long utf16Length;
> +    GOwnPtr<UChar> utf16Normalized;
> +    utf16Normalized.set(g_utf8_to_utf16(utf8Normalized.get(), -1, 0,
&utf16Length, 0));
> +
> +    return newTextCodec(*this)->encode(utf16Normalized.get(), utf16Length,
handling);


Regarding this, there's an exception to the camel case rule for acronyms, and
indeed all usages of "utf" in this file seem to be upper-cased, so I think we
should strive for consistency. This seems to be the only problem I am able to
spot by now. Sorry for being nit-picky, but please upload a patch with this
fixed so that we can use the commit queue =). Thanks!