[webkit-reviews] review requested: [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface : [Attachment 42001] Table Summary - with ARIA check
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 27 21:40:12 PDT 2009
Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked for review:
Bug 25534: [GTK] Objects of ROLE_TABLE should implement the accessible table
interface
https://bugs.webkit.org/show_bug.cgi?id=25534
Attachment 42001: Table Summary - with ARIA check
https://bugs.webkit.org/attachment.cgi?id=42001&action=review
------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
I tried to run the tests (Jan, thanks for your help/pointers!). But they all
claim to crash, e.g.:
dom/html/level1/core/hc_attrremovechild1.html -> crashed
So.... I will add learning about the tests to my list of things to do. In the
meantime, given the late hour....
The failed test is an ARIA one. I would think we could do a check for ARIA and
not do the new functionality if it is ARIA. That's what this patch does. To
"test" I compared what Accerciser reported as the accessible description
without my patch with what it reports with it. According to Accerciser, the
values are the same. <fingers crossed>
If someone wouldn't mind tossing the regression tests at this patch, I would
really, really appreciate it. Thanks!
More information about the webkit-reviews
mailing list