[webkit-reviews] review granted: [Bug 30047] Incomplete repaint of text field in relative positioned inline at imdb.com : [Attachment 41989] Implement offsetFromContainer(), mapLocalToContainer() and mapAbsoluteToLocalPoint() in RenderInline

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 30047: Incomplete repaint of text field in relative positioned inline at
imdb.com
https://bugs.webkit.org/show_bug.cgi?id=30047

Attachment 41989: Implement offsetFromContainer(), mapLocalToContainer() and
mapAbsoluteToLocalPoint() in RenderInline
https://bugs.webkit.org/attachment.cgi?id=41989&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +void RenderInline::mapLocalToContainer(RenderBoxModelObject*
repaintContainer, bool useTransforms, bool fixed, TransformState&
transformState) const

> +    bool preserve3D = useTransforms && (o->style()->preserves3D() ||
style()->preserves3D());
> +    if (useTransforms && shouldUseTransformFromContainer(o)) {

I don't think you'll ever fall into this path.shouldUseTransformFromContainer()
checks to see if the layer has a transform, and that will never happen for
inlines.

> +    if (useTransforms && shouldUseTransformFromContainer(o)) {

Ditto

r=me with those changes if you agree.